Add method to get non-trait shapes #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a method to ModelTransformer to get all shapes from a model that are not only used as part of a trait or definition of a trait. This makes it easier for code generators to get a shape index that contains only shapes that they typically want to generate. A convenience method was added to PluginContext to make this more apparent when implementing SmithyBuild plugins. The result is also cached since it can be an expensive thing to compute.
kstich
approved these changes
Sep 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a method to ModelTransformer to get all shapes from a
model that are not only used as part of a trait or definition of a
trait. This makes it easier for code generators to get a shape index
that contains only shapes that they typically want to generate.
A convenience method was added to PluginContext to make this more
apparent when implementing SmithyBuild plugins. The result is also
cached since it can be an expensive thing to compute.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.