Add exclude/include tranforms using selectors #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
requested changes
Dec 13, 2022
smithy-build/src/main/java/software/amazon/smithy/build/transforms/IncludeShapesBySelector.java
Outdated
Show resolved
Hide resolved
smithy-build/src/main/java/software/amazon/smithy/build/transforms/ExcludeShapesBySelector.java
Outdated
Show resolved
Hide resolved
smithy-build/src/main/java/software/amazon/smithy/build/transforms/ExcludeShapesBySelector.java
Outdated
Show resolved
Hide resolved
smithy-build/src/main/java/software/amazon/smithy/build/transforms/IncludeShapesBySelector.java
Show resolved
Hide resolved
sugmanue
force-pushed
the
tranform-by-selector
branch
from
b642db0 to
0a389fe
Compare
syall
reviewed
Dec 13, 2022
| @@ -298,6 +298,49 @@ Only the following shape type changes are supported: | |||
| } | |||
|
|
|||
|
|
|||
| .. _excludeShapesBySelector-transform: | |||
There was a problem hiding this comment.
Missing the port to 2.0 docs.
There was a problem hiding this comment.
🤦 I'll fix that, it should only be for the 2.0 docs.
sugmanue
force-pushed
the
tranform-by-selector
branch
from
0a389fe to
9f18b76
Compare
sugmanue
force-pushed
the
tranform-by-selector
branch
from
9f18b76 to
1183be3
Compare
jvschneid
approved these changes
Jan 10, 2023
mtdowling
approved these changes
Jan 10, 2023
AndrewFossAWS
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Added include/exclude transforms using selectors. Using selectors is a generic way to include or exclude shapes, instead of adding specific transforms such as
byShapeType(e.g., this PR) a selector can be used to replace that and other use cases.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.