Fix Upgrade1to2Command for Set shape #1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syall
reviewed
Jan 5, 2023
smithy-cli/src/main/java/software/amazon/smithy/cli/commands/Upgrade1to2Command.java
Outdated
Show resolved
Hide resolved
AndrewFossAWS
force-pushed
the
set-upgrade
branch
from
c686d62 to
d374e8a
Compare
sugmanue
reviewed
Jan 7, 2023
smithy-cli/src/main/java/software/amazon/smithy/cli/commands/Upgrade1to2Command.java
Outdated
Show resolved
Hide resolved
AndrewFossAWS
force-pushed
the
set-upgrade
branch
from
d374e8a to
97b04f8
Compare
sugmanue
reviewed
Jan 9, 2023
smithy-cli/src/main/java/software/amazon/smithy/cli/commands/Upgrade1to2Command.java
Outdated
Show resolved
Hide resolved
syall
suggested changes
Jan 9, 2023
smithy-cli/src/main/java/software/amazon/smithy/cli/commands/Upgrade1to2Command.java
Outdated
Show resolved
Hide resolved
AndrewFossAWS
force-pushed
the
set-upgrade
branch
2 times, most recently
from
8b39977 to
051c6ea
Compare
syall
approved these changes
Jan 9, 2023
smithy-cli/src/main/java/software/amazon/smithy/cli/commands/Upgrade1to2Command.java
Outdated
Show resolved
Hide resolved
AndrewFossAWS
force-pushed
the
set-upgrade
branch
from
051c6ea to
8dcd661
Compare
sugmanue
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Smithy IDL 1 contains set shapes, but IDL 2 does not. When upgrading from IDL 1, set shapes should be converted to list shapes. The upgrade command currently does not perform this conversion.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.