Fix FilterSuppressions to match on hierarchy #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordonPhillips
approved these changes
Feb 24, 2023
srchase
force-pushed
the
removeUnused-event-id-hierarchy
branch
from
af5a8c6 to
dfdecda
Compare
JordonPhillips
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hierarchical eventIds were added in #1527.
This PR fixes the FilterSuppressions transform to keep suppressions that match a prefix when using the
removeUnusedtransform configuration.Currently,
@suppress(['A'])will be removed as unused if a validation event does not matchAexactly.This PR updates the transform retain
@suppress(['A'])when a validation event forA.Bhas been emitted for the shape where the suppression was applied.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.