Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce IDL ambiguity by replacing *WS with [WS] #1699

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Reduce IDL ambiguity by replacing *WS with [WS] #1699

merged 1 commit into from
Mar 31, 2023

Conversation

hlbarber
Copy link
Contributor

@hlbarber hlbarber commented Mar 30, 2023 •
edited
Loading

#1249

A grammar containing

WS = *1( ... )
... = ... *WS ...

defines multiple parse trees.

We can eliminate the ambiguity by replacing *WS with [WS].

@hlbarber hlbarber requested a review from a team as a code owner March 30, 2023 22:17
JordonPhillips
JordonPhillips approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@JordonPhillips JordonPhillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for other readers: the ws production already defines it as one or more.

@mtdowling mtdowling merged commit f8db34d into smithy-lang:main Mar 31, 2023
@hlbarber hlbarber deleted the harryb/remove-ws-ambiguity branch March 31, 2023 23:24
@hlbarber hlbarber mentioned this pull request Apr 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JordonPhillips JordonPhillips JordonPhillips approved these changes

@mtdowling mtdowling mtdowling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hlbarber @mtdowling @JordonPhillips