Make smithy diff default to arbitrary diff mode #1718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smithy Diff should require --new, and --old models, and perform arbitrary diffs by defualt, meaning the diff does not use imports or sources found in smithy-build.json files. This matches the previous behavior of smithy diff. We will add more diff modes later that will support loading models defined in project config files. Smithy Diff should only accept a single --old and --new argument to make it easier to expand diff capabilities in the future.
sugmanue
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Smithy Diff should require --new, and --old models, and perform arbitrary diffs by defualt, meaning the diff does not use imports or sources found in smithy-build.json files. This matches the previous behavior of smithy diff. We will add more diff modes later that will support loading models defined in project config files.
Smithy Diff should only accept a single --old and --new argument to make it easier to expand diff capabilities in the future.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.