Fix grammar issues, add Comma production #1783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced "EnumShapeStatement" rule with "EnumStatement" because other shape statements don't include the word "Shape". Renamed "NodeKeywords" to "NodeKeyword" since grammar rules aren't generally plural like this. Added "Comma" production, which is now used in WS and can be optionally used after defining an enum member. Members that support value assignment can now have a trailing comma. Fixed WS loop handling for several productions. Fixed OperationErrors to actually support a list of ShapeId, rather than just a list of Identifier. Identifier implies that you can only use errors in the local namespace which isn't the case.
milesziemer
approved these changes
May 22, 2023
sugmanue
reviewed
May 23, 2023
| @@ -148,7 +148,7 @@ string support defined in `RFC 5234 <https://www.rfc-editor.org/rfc/rfc7405>`_. | |||
| Minus :%x2D ; - | |||
| Plus :%x2B ; + | |||
| Zero :%x30 ; 0 | |||
| NodeKeywords :%s"true" / %s"false" / %s"null" | |||
| NodeKeyword :%s"true" / %s"false" / %s"null" | |||
There was a problem hiding this comment.
Nit, missing space to align the colon as the rest of the productions.
sugmanue
approved these changes
May 23, 2023
milesziemer
added a commit
to milesziemer/smithy
that referenced
this pull request
May 24, 2023
https://github.com/awslabs/smithy/pull/1782/files clobbered changes in smithy-lang#1783, which this commit fixes.
milesziemer
added a commit
that referenced
this pull request
May 24, 2023
https://github.com/awslabs/smithy/pull/1782/files clobbered changes in #1783, which this commit fixes.
syall
pushed a commit
to Xtansia/smithy
that referenced
this pull request
Aug 11, 2023
https://github.com/awslabs/smithy/pull/1782/files clobbered changes in smithy-lang#1783, which this commit fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced "EnumShapeStatement" rule with "EnumStatement" because other shape statements don't include the word "Shape".
Renamed "NodeKeywords" to "NodeKeyword" since grammar rules aren't generally plural like this.
Added "Comma" production, which is now used in WS and can be optionally used after defining an enum member.
Members that support value assignment can now have a trailing comma.
Fixed WS loop handling for several productions.
Fixed OperationErrors to actually support a list of ShapeId, rather than just a list of Identifier. Identifier implies that you can only use errors in the local namespace which isn't the case.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.