Merge aggregate, structure shape grammar/parsing #1790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit combines aggregate shapes (list, map, union) and structure shapes in the grammar and parser. Previously, the way these shapes were defined only differed by aggregate shapes not allowing `for <resource>` syntax. With this change, aggregate shapes can now use `for <resource>` syntax and elide resource identifiers/properties. The parser was also updated so parsing inline structures uses the same method of parsing aggregate shapes. Tests making sure `for <resource>` couldn't be used with non structure shapes were removed, and tests were added for verifying `for <resource>` behavior with lists, maps, and unions. The tests added for list/map/union elided members in elided-members.smithy mirror the tests for structure shapes in the same file. This also updates the naming of shape productions in the grammar.
milesziemer
force-pushed
the
merge-aggregate-shape-parsing
branch
from
91f9658 to
1ed12eb
Compare
mtdowling
approved these changes
May 25, 2023
syall
pushed a commit
to Xtansia/smithy
that referenced
this pull request
Aug 11, 2023
This commit combines aggregate shapes (list, map, union) and structure shapes in the grammar and parser. Previously, the way these shapes were defined only differed by aggregate shapes not allowing `for <resource>` syntax. With this change, aggregate shapes can now use `for <resource>` syntax and elide resource identifiers/properties. The parser was also updated so parsing inline structures uses the same method of parsing aggregate shapes. Tests making sure `for <resource>` couldn't be used with non structure shapes were removed, and tests were added for verifying `for <resource>` behavior with lists, maps, and unions. The tests added for list/map/union elided members in elided-members.smithy mirror the tests for structure shapes in the same file. This also updates the naming of shape productions in the grammar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit combines aggregate shapes (list, map, union) and structure shapes in the grammar and parser. Previously, the way these shapes were defined only differed by aggregate shapes not allowing
for <resource>syntax. With this change, aggregate shapes can now usefor <resource>syntax and elide resource identifiers/properties.Tests making sure
for <resource>couldn't be used with non structure shapes were removed, and tests were added for verifyingfor <resource>behavior with lists, maps, and unions. The tests added for list/map/union elided members in elided-members.smithy mirror the tests for structure shapes in the same file.This also updates the naming of shape productions in the grammar.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.