Disable URLConnection cache in CLI #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running Smithy in a build tool like Gradle, Smithy is run multiple times within a thread. Java's URLConnection has a cache built-in for loading JARs, and when a JAR is updated during a Smithy build, it can cause checksum exceptions when attempting to load that same JAR from a subsequent run through the cache. This commit disables the cache when running Smithy through the CLI to prevent this issue (Gradle runs Smithy via the CLI in a thread).
mtdowling
commented
Oct 4, 2019
| @@ -142,7 +157,6 @@ public ModelAssembler reset() { | |||
| validators.clear(); | |||
| suppressions.clear(); | |||
| documentNodes.clear(); | |||
| properties.clear(); | |||
There was a problem hiding this comment.
These properties should have never of been cleared during a call to reset(). Reset should clear out transient state of the assembler, not configuration like properties.
kstich
approved these changes
Oct 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running Smithy in a build tool like Gradle, Smithy is run multiple
times within a thread. Java's URLConnection has a cache built-in for
loading JARs, and when a JAR is updated during a Smithy build, it can
cause checksum exceptions when attempting to load that same JAR from a
subsequent run through the cache. This commit disables the cache when
running Smithy through the CLI to prevent this issue (Gradle runs Smithy
via the CLI in a thread).
(I couldn't find a way to test this other than manually test that it fixed the issues I was running into when using it with the Gradle plugin)