Improve member trait querys and fix JSON bug #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug in the JSON schema converter where a member was not being excluded if the shape targeted by the member is marked as private. To address this in a way that helps other write similar code, I made an abstractions for querying the effective traits of a member based on a query object that can be extended in the future. I also moved the getMemberTrait and findMemberTrait methods to Shape itself rather than just on MemberShape to make them easier to use in situations where you want to get traits from a shape in a normalized way across regular shapes and member shapes.
kstich
approved these changes
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug in the JSON schema converter where a member was
not being excluded if the shape targeted by the member is marked as
private. To address this in a way that helps other write similar code, I
made an abstractions for querying the effective traits of a member based
on a query object that can be extended in the future. I also moved the
getMemberTrait and findMemberTrait methods to Shape itself rather than
just on MemberShape to make them easier to use in situations where you
want to get traits from a shape in a normalized way across regular
shapes and member shapes.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.