Clean up and rewrite spec for XML bindings #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
force-pushed
the
clean-up-xml-traits
branch
from
02f1d40 to
aacc3ce
Compare
kstich
requested changes
Jan 6, 2020
smithy-model/src/main/resources/software/amazon/smithy/model/loader/prelude-traits.smithy
Outdated
Show resolved
Hide resolved
This commit updates the XML traits spec to be made more generic and framed in terms of binding to XML. XML traits have been restricted to only apply to shapes in which they are actually supported. Many more examples have been added to the XML spec (note that I selectively did not include a JSON equivalent example when a JSON example adds no expository value).
mtdowling
force-pushed
the
clean-up-xml-traits
branch
from
aacc3ce to
9f88918
Compare
Because union shapes can be targeted by the httpPayload trait, we need to allow xmlName on unions to alter the outermost wrapper that is used to serialize the union when using a REST + XML protocol.
kstich
approved these changes
Jan 6, 2020
JordonPhillips
approved these changes
Jan 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the XML traits spec to be made more generic and
framed in terms of binding to XML. XML traits have been restricted to
only apply to shapes in which they are actually supported. Many more
examples have been added to the XML spec (note that I selectively did
not include a JSON equivalent example when a JSON example adds no
expository value).
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.