Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ec2QueryNameTrait #251

Merged
merged 2 commits into from
Jan 10, 2020

Conversation

JordonPhillips
Copy link
Contributor

This adds a trait to specify the name of an EC2 structure member when
it is used as an input.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

"selector": "member:of(structure)"
},
"smithy.api#documentation": "Indicates the serialized name of a structure member when that structure is serialized for the input of an EC2 operation.",
"smithy.api#pattern": "^[a-zA-Z_][a-zA-Z_0-9-]*(:[a-zA-Z_][a-zA-Z_0-9-]*)?$"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did this come from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same as the xmlname pattern

@JordonPhillips JordonPhillips force-pushed the ec2-query-name branch 2 times, most recently from 34e2956 to 97da568 Compare January 10, 2020 17:25
This adds a trait to specify the name of an EC2 structure member when
it is used as an input.
@JordonPhillips
Copy link
Contributor Author

Updates: added the license bit and updated the pattern to not include a : which only made sense in the context of xml

@mtdowling mtdowling self-requested a review January 10, 2020 18:21
@JordonPhillips JordonPhillips merged commit bcaf8b6 into smithy-lang:master Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants