Use Gradle plugin to build protocol tests #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
force-pushed
the
use-gradle-plugin
branch
from
ed1451e to
6d2c51e
Compare
mtdowling
changed the title
|
Note that this depends on the Gradle plugin being released first. |
mtdowling
force-pushed
the
use-gradle-plugin
branch
from
6d2c51e to
9dbae1f
Compare
mtdowling
force-pushed
the
use-gradle-plugin
branch
from
9dbae1f to
6df3f6c
Compare
JordonPhillips
approved these changes
Jan 23, 2020
mtdowling
force-pushed
the
use-gradle-plugin
branch
from
6df3f6c to
2631fdd
Compare
AWS protocol tests: - Use the Gradle plugin to build the AWS protocol tests. SmithyBuild: - Only run parallel projections if there's more than one. SmithyCli (breaking CLI changes): - to allow the writing to stderr and stdout to be completely customized using a Consumer<String>. This allows the Gradle plugin to log writes to stdout rather than rely on the non-thread-safe default behavior of intercepting calls. - Colors nows is used by calling out and err directly on an enum variant rather than a static method. - Adding the --logging parameter to every command and removed the static `configureLogging` method. - Adding `stdout` and `stderr` methods to the Cli. These are now called by Colors when writing. - Enabling disabling ANSI colors is done on Cli and not on Colors now. All of the methods used to influence the CLI globally is now all on the Cli. - Logging is only configured when a logging option is passed in. A custom logger is used that makes calls to the intercepted stderr method. - Running `build` now shows validation results too. SmithyModel: - ValidationEvents are now sorted by filename, line number, column, severity, shape ID, message, then finally the event ID. - Introducing the ValidationEventFormatter interface. There are now implementations of the current display (showing the event on a single line like CheckStyle), and a contextual formatter that shows the line of the source file that has the error.
mtdowling
force-pushed
the
use-gradle-plugin
branch
from
2631fdd to
0fbc82a
Compare
|
This has been updated to use 0.4.3 of the Gradle plugin |
This commit updates SmithyTestSuite to support easily running test suites as JUnit 5 ParameterizedTests. This allows JUnit to control how tests are executed and provides better error reporting. Tests seem to execute more or less in the same amount of time as before.
JordonPhillips
approved these changes
Jan 27, 2020
kstich
approved these changes
Jan 27, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make various improvements geared towards Gradle/CLI
AWS protocol tests:
SmithyBuild:
SmithyCli (breaking CLI changes):
using a Consumer. This allows the Gradle plugin to log writes
to stdout rather than rely on the non-thread-safe default behavior of
intercepting calls.
rather than a static method.
configureLoggingmethod.stdoutandstderrmethods to the Cli. These are now calledby Colors when writing.
All of the methods used to influence the CLI globally is now all on
the Cli.
custom logger is used that makes calls to the intercepted stderr
method.
buildnow shows validation results too.SmithyModel:
severity, shape ID, message, then finally the event ID.
now implementations of the current display (showing the event on
a single line like CheckStyle), and a contextual formatter that
shows the line of the source file that has the error.