Add RenameShapes model transformer #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
requested changes
Mar 17, 2020
smithy-model/src/main/java/software/amazon/smithy/model/transform/RenameShapes.java
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/transform/RenameShapes.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/transform/RenameShapes.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/transform/RenameShapes.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/transform/ModelTransformer.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/transform/RenameShapes.java
Outdated
Show resolved
Hide resolved
smithy-model/src/test/java/software/amazon/smithy/model/transform/RenameShapesTest.java
Outdated
Show resolved
Hide resolved
smithy-model/src/test/java/software/amazon/smithy/model/transform/RenameShapesTest.java
Outdated
Show resolved
Hide resolved
smithy-model/src/test/java/software/amazon/smithy/model/transform/RenameShapesTest.java
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,25 @@ | |||
| { | |||
There was a problem hiding this comment.
For this integration test, I'd like to see metadata getting renamed (e.g., a suppression) and tests for virtually every kind of shape and reference -- structures, lists, maps, sets, unions, services, operations, etc.
There was a problem hiding this comment.
It looks like this is missing validation for updating some relationships:
- service -> operation
- service -> resource
- resource -> identifier
- resource -> operation
mtdowling
requested changes
Mar 18, 2020
smithy-model/src/main/java/software/amazon/smithy/model/transform/RenameShapes.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/transform/RenameShapes.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/transform/ModelTransformer.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/transform/ModelTransformer.java
Outdated
Show resolved
Hide resolved
smithy-model/src/test/java/software/amazon/smithy/model/transform/RenameShapesTest.java
Outdated
Show resolved
Hide resolved
srchase
requested review from
mtdowling and
kstich
and removed request for
mtdowling
kstich
requested changes
Mar 23, 2020
smithy-model/src/test/java/software/amazon/smithy/model/transform/RenameShapesTest.java
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,25 @@ | |||
| { | |||
There was a problem hiding this comment.
It looks like this is missing validation for updating some relationships:
- service -> operation
- service -> resource
- resource -> identifier
- resource -> operation
smithy-model/src/main/java/software/amazon/smithy/model/transform/ModelTransformer.java
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/transform/ModelTransformer.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/transform/RenameShapes.java
Outdated
Show resolved
Hide resolved
added 2 commits
March 23, 2020 14:45
kstich
approved these changes
Mar 24, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a RenameShapes model transformer that takes a map of ShapeId to ShapeId pairs.
Shape members are updated for consistency when any member-containing aggregate shape has been renamed.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.