Migrate UnreferencedShapeValidator #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srchase
changed the title
JordonPhillips
approved these changes
Mar 20, 2020
|
probably want to squash some of those commits |
JordonPhillips
pushed a commit
to JordonPhillips/smithy
that referenced
this pull request
Apr 22, 2020
* Migrate linter to validator * Add references on test models * Update linters test models
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #241 by migrating the existing UnreferencedShapeValidator from smithy-linters to smithy-model so that the validation is always run against the model.
A check is added so that only models with services will emit
notevalidation events when a shape is not referenced within the model.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.