Update open api json schema pojos #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
force-pushed
the
update-open-api-json-schema-pojos
branch
from
1d9b034 to
64aad7d
Compare
The OpenAPI plugin has now been refactored to use strongly-typed POJOs rather than the more dynamic Node-based configuration. This is possible because of the NodeMapper. Now OpenAPI's config extends from JSON Schema's config. All configuration prefixes were removed from OpenAPI keys, but the plugin will handle loading the deprecated form of "openapi." when parsing configuration settings. Additional configuration settings used to configure conversion plugins for either OpenAPI or JSON Schema are contained in the "extensions" property. This property can be access from the JsonSchemaConfig object and deserialized into a desired POJO using `getExtensions(Class type)`. This allows typed access to additional configuration settings along with validation. Subsequent access to the same type is cached.
mtdowling
force-pushed
the
update-open-api-json-schema-pojos
branch
from
64aad7d to
cbf8f2e
Compare
kstich
requested changes
Apr 9, 2020
smithy-jsonschema/src/main/java/software/amazon/smithy/jsonschema/Schema.java
Outdated
Show resolved
Hide resolved
smithy-openapi/src/main/java/software/amazon/smithy/openapi/fromsmithy/Smithy2OpenApi.java
Outdated
Show resolved
Hide resolved
kstich
approved these changes
Apr 9, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.