Mark node validation visitors internal #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NodeValidationVisitors need to be refactored so that they emit validation events with proper source locations (right now they aren't tied to any source location). This will require changing the API of NodeValidatorPlugin implementations, which would be a breaking change. Because of this, I'm marking these APIs as internal, which will allow us to safely break these APIs and improve them when we have the time.
kstich
approved these changes
Apr 16, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NodeValidationVisitors need to be refactored so that they emit
validation events with proper source locations (right now they aren't
tied to any source location). This will require changing the API of
NodeValidatorPlugin implementations, which would be a breaking change.
Because of this, I'm marking these APIs as internal, which will allow us
to safely break these APIs and improve them when we have the time.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.