Make annotation traits lossless #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates annotation traits to now accept an ObjectNode that contains the actual value found in a model rather than just the source location. This makes it possible to a) validate that the values provided for an annotation trait are valid b) persist unknown annotation trait properties when serializing a model. Extraneous trait properties previously resulted in an ERROR, but now they are a WARNING, since adding new properties isn't meant to be a breaking change.
kstich
approved these changes
Apr 17, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates annotation traits to now accept an ObjectNode that
contains the actual value found in a model rather than just the source
location. This makes it possible to a) validate that the values provided
for an annotation trait are valid b) persist unknown annotation trait
properties when serializing a model. Extraneous trait properties
previously resulted in an ERROR, but now they are a WARNING, since
adding new properties isn't meant to be a breaking change.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.