Remove non-idiomatic ShapeVisitor builder #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously had a builder that could create a ShapeVisitor from a bunch of closures. This is actually not very idiomatic Java when compared to just implementing an anonymous class that implements ShapeVisitor.Default.
kstich
approved these changes
May 4, 2020
| ShapeVisitor<List<ValidationEvent>> visitor = new ShapeVisitor.Default<List<ValidationEvent>>() { | ||
| @Override | ||
| protected List<ValidationEvent> getDefault(Shape shape) { | ||
| if (shape.isStringShape() || shape instanceof NumberShape) { |
There was a problem hiding this comment.
The expansion on this to be NumberShape means a few more shape types will be validated: byte, double, and the Big* numbers. Seems like that would be intended but calling out in case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously had a builder that could create a ShapeVisitor from a
bunch of closures. This is actually not very idiomatic Java when
compared to just implementing an anonymous class that implements
ShapeVisitor.Default.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.