Update json protocol tests #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordonPhillips
changed the title
JordonPhillips
force-pushed
the
update-aws-json-protocol-tests
branch
from
dc1dffa to
b1fa3af
Compare
|
Would you mind duplication some of these tests for rest-json as well? Underlying implementations by serder should be the same, but would help for completeness. |
JordonPhillips
changed the title
JordonPhillips
force-pushed
the
update-aws-json-protocol-tests
branch
2 times, most recently
from
c64607a to
e7c1ca2
Compare
Some of the timestamp deserialization tests were using the wrong members, so this fixes that.
JordonPhillips
force-pushed
the
update-aws-json-protocol-tests
branch
from
e7c1ca2 to
c7807ce
Compare
JordonPhillips
changed the title
mtdowling
approved these changes
Jul 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some protocol tests for
awsJson1_1to assert behavior surrounding null and enums. It also fixes some timestamp tests that were using the wrong members.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.