Add :topdown selector to match hierarchically #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstich
reviewed
Aug 28, 2020
smithy-model/src/main/java/software/amazon/smithy/model/selector/TopDownSelector.java
Outdated
Show resolved
Hide resolved
mtdowling
force-pushed
the
add-topdown-selector
branch
from
0808e7b to
661c316
Compare
kstich
reviewed
Sep 9, 2020
mtdowling
force-pushed
the
add-topdown-selector
branch
from
661c316 to
3e21393
Compare
kstich
approved these changes
Sep 9, 2020
mtdowling
force-pushed
the
add-topdown-selector
branch
from
3e21393 to
27acf7d
Compare
The topdown selector is used to match shapes hierarchically based on a "qualifier" selector and optional "disqualifier" selector. This can be used to match shapes that are marked as controlPlane or dataPlane using inheritance from resource/service bindings, match shapes that use httpBasic auth, etc.
mtdowling
force-pushed
the
add-topdown-selector
branch
from
27acf7d to
8a624c1
Compare
kstich
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The topdown selector is used to match shapes hierarchically based on a match selector and optional disqualifier selector. This can be used to match shapes that are marked as controlPlane or dataPlane using
inheritance from resource/service bindings, match shapes that use httpBasic auth, etc.
Note: This probably needs more docs, but I wanted to push it up to make sure it looks useful.