Emit DANGER event for DELETE with a payload #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lots of clients don't support DELETE with a payload, and the spec calls it out as having no defined semantics. The newly added event can be suppressed if necessary, but this action functions as a way of essentially "signing-off" on the risks associated with using a DELETE with a payload.
mtdowling
force-pushed
the
delete-with-payload-validation
branch
from
324edb3 to
67377b7
Compare
kstich
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of clients don't support DELETE with a payload, and the spec calls
it out as having no defined semantics. The newly added event can be
suppressed if necessary, but this action functions as a way of essentially
"signing-off" on the risks associated with using a DELETE with a payload.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.