Add CloudFormation Resource Schema generation #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstich
changed the title
mtdowling
requested changes
Nov 5, 2020
There was a problem hiding this comment.
Did you consider adding a kind of test runner using directories that contain a smithy model and all the expected generated JSON files? I got the feeling that there wasn't a ton of test coverage, particularly integration tests to ensure we generate the right output.
...src/test/java/software/amazon/smithy/aws/cloudformation/schema/fromsmithy/CfnConfigTest.java
Outdated
Show resolved
Hide resolved
...ion/src/main/java/software/amazon/smithy/aws/cloudformation/schema/model/ResourceSchema.java
Show resolved
Hide resolved
...ion/src/main/java/software/amazon/smithy/aws/cloudformation/schema/model/ResourceSchema.java
Outdated
Show resolved
Hide resolved
.../src/main/java/software/amazon/smithy/aws/cloudformation/schema/fromsmithy/CfnConverter.java
Outdated
Show resolved
Hide resolved
.../src/main/java/software/amazon/smithy/aws/cloudformation/schema/fromsmithy/CfnConverter.java
Outdated
Show resolved
Hide resolved
.../src/main/java/software/amazon/smithy/aws/cloudformation/schema/fromsmithy/CfnConverter.java
Outdated
Show resolved
Hide resolved
.../src/main/java/software/amazon/smithy/aws/cloudformation/schema/fromsmithy/CfnConverter.java
Outdated
Show resolved
Hide resolved
.../src/main/java/software/amazon/smithy/aws/cloudformation/schema/fromsmithy/CfnConverter.java
Outdated
Show resolved
Hide resolved
kstich
force-pushed
the
add_cloudformation_conversion
branch
2 times, most recently
from
dd75157 to
7941baa
Compare
|
Migrated existing integ-like test cases to a test runner and added more cases from the trait documentation for mutability coverage, in addition to bolstering tests for the updates. |
mtdowling
requested changes
Nov 6, 2020
kstich
force-pushed
the
add_cloudformation_conversion
branch
from
7941baa to
c78cdba
Compare
mtdowling
approved these changes
Nov 7, 2020
kstich
force-pushed
the
add_cloudformation_traits
branch
from
ff3402b to
5bd9e9b
Compare
This commit introduces a new "cloudformation" build plugin that, given a model decorated with the aws.cloudformation traits, will generate CloudFormation Resource Schemas. This includes support for specifying the mutability of properties, their documentation, and more.
kstich
force-pushed
the
add_cloudformation_conversion
branch
from
c78cdba to
f42c516
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new "cloudformation" build plugin that, given
a model decorated with the aws.cloudformation traits, will generate
CloudFormation Resource Schemas. This includes support for specifying
the mutability of properties, their documentation, and more.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.