Fix Access-Control-Expose-Headers #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstich
reviewed
Dec 7, 2020
...napi/src/main/java/software/amazon/smithy/aws/apigateway/openapi/AddCorsResponseHeaders.java
Outdated
Show resolved
Hide resolved
This commit ensures that Access-Control-Expose-Headers is correctly populated based on all of the headers used in an operation, including any headers that might be added manually during the OpenAPI conversion independent of a Smithy shape. I added a new ApiGatewayMapper method called postProcessOperation to allow transformations to better control when they are applied, in particular, transforms sometimes need to occur on an operation after the things that the operation contains have been transformed. This was not previously possible even with the ordering semantics that already exist. This change was necessary in order to ensure that the correct CORs headers are added to operations based on all of the transforms applied to the operation, and it makes it easier to separate CORS headers from modeled headers when constructing Access-Control-Expose-Headers.
mtdowling
force-pushed
the
fix-cors-expose-headers
branch
from
b84b545 to
3046003
Compare
kstich
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures that Access-Control-Expose-Headers is correctly
populated based on all of the headers used in an operation, including
any headers that might be added manually during the OpenAPI conversion
independent of a Smithy shape.
I added a new ApiGatewayMapper method called postProcessOperation to
allow transformations to better control when they are applied, in
particular, transforms sometimes need to occur on an operation after the
things that the operation contains have been transformed. This was not
previously possible even with the ordering semantics that already exist.
This change was necessary in order to ensure that the correct CORs
headers are added to operations based on all of the transforms applied
to the operation, and it makes it easier to separate CORS headers from
modeled headers when constructing Access-Control-Expose-Headers.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.