Relax http payload constraints #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the httpPayload trait to be applied to sets, lists, and maps.
The AWS protocols do not currently support http payloads that target sets, lists, or maps. This adds validators to ensure that such bindings do not get used.
srchase
approved these changes
Jan 5, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Resolves #636
Description of changes:
This relaxes the http payload constraints so that it can be applied to members that target sets, lists, and maps. Since those targets aren't currently compatible with the AWS protocols, a validator was added that only applies if one of those protocol traits is applied.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.