Throw syntax exceptions on duplicate bindings #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like some windows-based newline issues, will take a look. |
kstich
force-pushed
the
add_dupe_key_checks
branch
5 times, most recently
from
fefe5c8 to
a7f785c
Compare
This commit updates the Smithy IDL parsing to throw when duplicate bindings or members are found in the following declarations: service, resource, and operation shapes, applied structure traits, and applied traits with members that are structures. This behavior is unsafe for model writers and shouldn't be valid.
kstich
force-pushed
the
add_dupe_key_checks
branch
from
a7f785c to
0c00d2c
Compare
mtdowling
approved these changes
Feb 17, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the Smithy IDL parsing to throw when duplicate
bindings or members are found in the following declarations: service,
resource, and operation shapes, applied structure traits, and applied
traits with members that are structures. This behavior is unsafe for
model writers and shouldn't be valid.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.