Set additionalProperties false for CFN objects #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a CfnMapper that defaults the `additionalProperties` property to `false` for named entries in a schema's `definitions` that are of the `object` type. This is recommended behavior by CloudFormation and, if not present, results in a warning when developing a resource.
kstich
requested review from
JordonPhillips,
mtdowling and
srchase
as code owners
srchase
approved these changes
Apr 8, 2021
JordonPhillips
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a CfnMapper that defaults the
additionalPropertiesproperty to
falsefor named entries in a schema'sdefinitionsthatare of the
objecttype. This is recommended behavior by CloudFormationand, if not present, results in a warning when developing a resource.
Fixes #750
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.