Stop validation on critical loading errors #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
requested review from
JordonPhillips,
kstich and
srchase
as code owners
We previously would continue to perform more granular semantic model validation even after an ERROR was encountered while loading the model. If an ERROR is encountered while loading a model, then it is very likely that it can cause a flurry of unrelated validation events to emit errors that would only obscure the root cause of the issue. This commit updates model validation to stop if an ERROR occurred while loading models, if a model has broken shape references, if a shape target targets an invalid shape, or if a resource hierarchy is recursive. This update required various "kitchen-sink" style tests to be updated to account for the new validation behavior. Closes #743
mtdowling
force-pushed
the
stop-on-critical-validation-errors
branch
from
7ca1ecb to
abcb699
Compare
JordonPhillips
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously would continue to perform more granular semantic model
validation even after an ERROR was encountered while loading the model.
If an ERROR is encountered while loading a model, then it is very likely
that it can cause a flurry of unrelated validation events to emit errors
that would only obscure the root cause of the issue.
This commit updates model validation to stop if an ERROR occurred while
loading models, if a model has broken shape references, if a shape
target targets an invalid shape, or if a resource hierarchy is
recursive. This update required various "kitchen-sink" style tests to be
updated to account for the new validation behavior.
Closes #743
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.