Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add structure xmlName wrapper test #789

Merged
merged 1 commit into from
May 3, 2021
Merged

Add structure xmlName wrapper test #789

merged 1 commit into from
May 3, 2021

Conversation

srchase
Copy link
Contributor

@srchase srchase commented Apr 29, 2021

Adds a rest-xml protocol test to ensure that xml wrapper name is set using the xmlName applied on the structure itself.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@JordonPhillips JordonPhillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't bound to a service

@srchase srchase force-pushed the xmlNameOnContainer branch from e6c76ed to 1fa9b20 Compare May 3, 2021 15:37
@srchase srchase force-pushed the xmlNameOnContainer branch from 1fa9b20 to 27f637b Compare May 3, 2021 16:02
documentation: "Serializes a payload using a wrapper name based on the xmlName",
protocol: restXml,
code: 200,
body: "<Ahoy><name>Phreddy</name></Ahoy>",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You sure this isn't supposed to be: <Ahoy><nested><name>Phreddy</name></nested></Ahoy>?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was fixed in #795

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants