Fix bug with cloudformation unions #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where having unions in your model would cause the cloudformation schema generation to fail.
mtdowling
approved these changes
May 10, 2021
There was a problem hiding this comment.
LGTM, but we could also look into a future change that fixes this as the shapes are converted to JSON Schema rather than mapping over the already created JSON Schema. Maybe using this: https://github.com/awslabs/smithy/blob/main/smithy-jsonschema/src/main/java/software/amazon/smithy/jsonschema/JsonSchemaMapper.java
kstich
approved these changes
May 11, 2021
There was a problem hiding this comment.
Agreed with @mtdowling on the update for later. I think we'll need to update Schema to be able to use a boolean for additionalProperties in addition to a nested Schema.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where having unions in your model would cause the
cloudformation schema generation to fail.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.