add new awsQuery tests for nested structs and fix endpoint test #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds tests lists/maps in a nested structure - Fix the expected version of the `AwsQueryEndpointTrait` test
aajtodd
requested review from
JordonPhillips,
kstich and
mtdowling
as code owners
JordonPhillips
approved these changes
Jun 15, 2021
@JordonPhillips Sure thing, do you want it in a separate PR or update this one? |
|
updating this one is good |
JordonPhillips
requested changes
Jun 16, 2021
| headers: { | ||
| "Content-Type": "application/x-www-form-urlencoded" | ||
| }, | ||
| body: "Action=QueryLists&Version=2020-01-08&NestedWithList.ListArg.member.1=A&NestedWithList.ListArg.member.2=B", |
There was a problem hiding this comment.
ec2 doesn't have the member segment - it looks like our docs are actually wrong on this
There was a problem hiding this comment.
Ahh good catch, haven't implemented EC2 protocol yet and missed that difference.
JordonPhillips
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
We ran into an issue with our serializer implementation on a real service (SES) that had a nested structure with list input (specifically SendEmailRequest.Destination$ToAddresses. I've added tests for both lists and maps (double check for correctness). Also there appears to be a broken test unless I'm mistaken, I've fixed that as well.
AwsQueryEndpointTraittestBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.