Update headers for sigv4 and restJson1 for apig #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the lists of headers needed for sigv4 and for the restJson1 protocol in the openapi conversion. It also ensures that those headers are added to cors configurations for apig.
This updates the openapi request/response header lists to account for the various http checksum traits.
kstich
requested changes
Jul 29, 2021
...src/main/java/software/amazon/smithy/aws/apigateway/openapi/AddCorsPreflightIntegration.java
Outdated
Show resolved
Hide resolved
.../src/main/java/software/amazon/smithy/openapi/fromsmithy/protocols/AbstractRestProtocol.java
Outdated
Show resolved
Hide resolved
.../src/main/java/software/amazon/smithy/openapi/fromsmithy/protocols/AbstractRestProtocol.java
Outdated
Show resolved
Hide resolved
...ay-openapi/src/main/java/software/amazon/smithy/aws/apigateway/openapi/ApiGatewayConfig.java
Show resolved
Hide resolved
JordonPhillips
force-pushed
the
cors-protocol-headers
branch
from
0b2b5e8 to
20e45b7
Compare
kstich
approved these changes
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the lists of headers needed for sigv4 and for the restJson1 protocol in the openapi conversion. It also ensures that those headers are added to cors configurations for apig.
A few notes:
X-Amzn-Trace-Idisn't present in responses.X-Amz-Retry-Aftersince only one SDK uses it, and it is mostly obsoleted by adaptive retries.X-Amz-Crc32. These can be configured if the service actually makes use of them.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.