Added scheme property to HttpApiKeyAuth trait #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidOgunsAWS
requested review from
JordonPhillips,
kstich and
mtdowling
as code owners
glb
reviewed
Aug 18, 2021
There was a problem hiding this comment.
Thank you @DavidOgunsAWS ! I can't claim that I know what's required to make this all work but everything here seems to make sense. One typo in the docs.
JordonPhillips
requested changes
Aug 19, 2021
smithy-model/src/main/java/software/amazon/smithy/model/traits/HttpApiKeyAuthTrait.java
Outdated
Show resolved
Hide resolved
...in/java/software/amazon/smithy/model/validation/validators/HttpApiKeyAuthTraitValidator.java
Outdated
Show resolved
Hide resolved
...in/java/software/amazon/smithy/model/validation/validators/HttpApiKeyAuthTraitValidator.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/resources/software/amazon/smithy/model/loader/prelude.smithy
Outdated
Show resolved
Hide resolved
...rces/software/amazon/smithy/linters/errorfiles/http-api-key-scheme-trait-validator-test.json
Outdated
Show resolved
Hide resolved
…oader/prelude.smithy Co-authored-by: Jordon Phillips <JordonPhillips@users.noreply.github.com>
|
@DavidOgunsAWS per this comment, I've discovered this code that I think needs to be updated as part of this PR. Thoughts? I wouldn't want this to go in and then be unable to fix the behaviour because it would break backwards compatibility. |
JordonPhillips
requested changes
Aug 20, 2021
DavidOgunsAWS
commented
Aug 20, 2021
...software/amazon/smithy/openapi/fromsmithy/security/http-api-key-bearer-security.openapi.json
Show resolved
Hide resolved
kstich
requested changes
Aug 23, 2021
smithy-model/src/main/java/software/amazon/smithy/model/traits/HttpApiKeyAuthTrait.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/traits/HttpApiKeyAuthTrait.java
Outdated
Show resolved
Hide resolved
smithy-model/src/test/java/software/amazon/smithy/model/traits/HttpApiKeyAuthTraitTest.java
Outdated
Show resolved
Hide resolved
smithy-model/src/test/java/software/amazon/smithy/model/traits/HttpApiKeyAuthTraitTest.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/resources/software/amazon/smithy/model/loader/prelude.smithy
Outdated
Show resolved
Hide resolved
...in/java/software/amazon/smithy/model/validation/validators/HttpApiKeyAuthTraitValidator.java
Outdated
Show resolved
Hide resolved
...in/java/software/amazon/smithy/model/validation/validators/HttpApiKeyAuthTraitValidator.java
Outdated
Show resolved
Hide resolved
kstich
reviewed
Aug 30, 2021
smithy-model/src/test/java/software/amazon/smithy/model/traits/HttpApiKeyAuthTraitTest.java
Outdated
Show resolved
Hide resolved
kstich
approved these changes
Aug 31, 2021
JordonPhillips
approved these changes
Sep 1, 2021
...re/amazon/smithy/model/errorfiles/validators/http-api-key-scheme-trait-validator-test.errors
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#872 being addressed.
Description of changes:
New scheme property for existing trait. Additional validation to restrict usage to in=header to allow only practical or known use cases.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.