Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared CSS loaded multiple times at axa.ch #492

Closed
1 of 2 tasks
AndyOGo opened this issue Jun 19, 2018 · 3 comments
Closed
1 of 2 tasks

Shared CSS loaded multiple times at axa.ch #492

AndyOGo opened this issue Jun 19, 2018 · 3 comments
Assignees
Milestone

Comments

@AndyOGo
Copy link

AndyOGo commented Jun 19, 2018

Are you reporting a bug or a feature?

  • Bug
  • Feature

Expected Behavior

Integrations of the patterns-library and various SPA's should not generate multiple duplicates of exact same CSS rules.

  • This increases load time
  • bloats our CSS, and thus the browsers memory
  • really bad for mobiles

Actual Behavior

Consuming the patterns-library's SASS and integration a third-party SPA like eClaim's UI-Renderer generates multiple duplicates of the same CSS.

@AndyOGo AndyOGo added this to the Build milestone Jun 19, 2018
@LucaMele
Copy link
Contributor

Closing as we are live with v2, if author think is still relevant, please re-open

@AndyOGo
Copy link
Author

AndyOGo commented May 13, 2019

@LucaMele I guess this is still valid too

@AndyOGo AndyOGo reopened this May 13, 2019
@LucaMele
Copy link
Contributor

LucaMele commented May 13, 2019

@AndyOGo please provide proof in V2, we should have fixed it with shadowDom and with this: https://github.com/axa-ch/patterns-library/blob/develop/src/utils/no-shadow.js. Feel free to submit a new issue if is still there in v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants