Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump required node version to v14 #226

Closed
axe312ger opened this issue Mar 28, 2022 · 0 comments
Closed

bump required node version to v14 #226

axe312ger opened this issue Mar 28, 2022 · 0 comments
Milestone

Comments

@axe312ger
Copy link
Owner

@axe312ger Thanks for the reply and your quick release. Unfortunately it did not help.

To answer your first question: Yes there is a node_modules/sqip-plugin-primitive/package.json with a valid main entry point. But I think I found the issue. It's due to node version v12.22.3 we are using. Package 'fs/promises' is not available in this version and the plugin fails to load.

I found some comments about it, pretty weird: 'fs/promises' was being introduced in Node 10 but then removed in later patches for Node 10 and Node 12. Works fine in Node 14. Node.js documentation was incorrectly listing this as supported in Node 12 (nodejs/node#35740).

So I guess we have to tell our hoster, that we need a node version bump.

Originally posted by @rrutsche in #221 (comment)

@axe312ger axe312ger added this to the 1.0.0 milestone Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant