Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Files accessible through axolotl #140

Closed
bjoern-tantau opened this issue May 13, 2020 · 4 comments
Closed

[BUG] Files accessible through axolotl #140

bjoern-tantau opened this issue May 13, 2020 · 4 comments

Comments

@bjoern-tantau
Copy link

Description

Through /attachments I have access to every file axolotl has access to. This is especially problematic when the webserver isn't restricted to localhost because then everyone in the network can access the files.

Steps to Reproduce

Open
http://localhost:9080/attachments?file=/etc/passwd in a browser

Expected behavior:

Browser gets a 403 for every file outside of the attachments folder.

Actual behavior:

I get the contents of /etc/passwd

Versions

0.8.2

@bjoern-tantau bjoern-tantau changed the title [BUG] File [BUG] Files accessible through axolotl May 13, 2020
@nanu-c
Copy link
Collaborator

nanu-c commented May 13, 2020

I will fix it asap, thanks for reporting

@Blackoverflow
Copy link
Collaborator

@nanu-c my idea of fixing this would be to use the filename instead the full path as parameter. Should I give it a shot?

@nanu-c
Copy link
Collaborator

nanu-c commented Jun 9, 2020

For sure, if you want to try it. But the problem is, that the attachment has the fullpath and asks for it.

@nanu-c
Copy link
Collaborator

nanu-c commented Aug 14, 2020

Actually this bug is not so important in confined envirments. Nevertheless it's fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants