Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(core): evalStore not a constructor error on production build #35

Open
ayoayco opened this issue Mar 10, 2024 · 1 comment
Open

bug(core): evalStore not a constructor error on production build #35

ayoayco opened this issue Mar 10, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@ayoayco
Copy link
Owner

ayoayco commented Mar 10, 2024 •
edited
Loading

Seems to be caused by Storage.getItem() giving back unexpected value (numbers) instead of the content of server asset files which we evaluate and pass to an evalStore, which is expected to be a constructor.

To recreate, use nitropack@latest in all packages & sites

This is temporarily fixed with #36 -- If encountered in your project, please update packages to their latest version:

  1. @mcflyjs/core
  2. @mcflyjs/config
@ayoayco ayoayco added the bug Something isn't working label Mar 10, 2024
@ayoayco ayoayco changed the title bug: evalStore not a constructor error on production build bug(core): evalStore not a constructor error on production build Mar 10, 2024
@ayoayco
Copy link
Owner Author

ayoayco commented Mar 10, 2024 •
edited
Loading

Logging content from Storage.getItem() on production build vs on dev server...

On build:
Screenshot 2024-03-10 at 18 00 52

On dev server:
Screenshot 2024-03-10 at 18 03 24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ayoayco