From 4fdf87b29dbe1d2e58d7cf385a896df7267aaf60 Mon Sep 17 00:00:00 2001 From: Refael Ackermann Date: Sat, 21 Oct 2017 18:07:19 -0400 Subject: [PATCH] test: change tmp directories prefix `.tmp` prefix allows easier exclusion PR-URL: https://github.com/nodejs/node/pull/16372 Refs: https://github.com/nodejs/node/pull/16010 Refs: https://github.com/nodejs/node/issues/16278 Reviewed-By: Rich Trott Reviewed-By: Joyee Cheung Reviewed-By: Luigi Pinca Reviewed-By: Gibson Fahnestock Reviewed-By: James M Snell --- .eslintignore | 1 - test/common/index.js | 4 +++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.eslintignore b/.eslintignore index 023979a515..011ec96362 100644 --- a/.eslintignore +++ b/.eslintignore @@ -2,7 +2,6 @@ lib/internal/v8_prof_polyfill.js lib/punycode.js test/addons/??_* test/fixtures -test/tmp* tools/eslint tools/icu node_modules diff --git a/test/common/index.js b/test/common/index.js index 8ccbc0e0df..76b86b6772 100644 --- a/test/common/index.js +++ b/test/common/index.js @@ -38,7 +38,9 @@ const noop = () => {}; exports.fixturesDir = fixturesDir; -exports.tmpDirName = 'tmp'; +// Using a `.` prefixed name, which is the convention for "hidden" on POSIX, +// gets tools to ignore it by default or by simple rules, especially eslint. +exports.tmpDirName = '.tmp'; // PORT should match the definition in test/testpy/__init__.py. exports.PORT = +process.env.NODE_COMMON_PORT || 12346; exports.isWindows = process.platform === 'win32';