From 54c6b0c67c017977ca8554f12dfd305f0399976f Mon Sep 17 00:00:00 2001
From: Ayush Newatia <ayush@hey.com>
Date: Wed, 16 Jun 2021 23:59:30 +0100
Subject: [PATCH] Complete test suite

---
 lib/bridgetown-svg-inliner/builder.rb         |  2 +-
 .../liquid_attributes.rb                      |  2 +-
 test/fixtures/src/_data/site_metadata.yml     |  2 +-
 test/fixtures/src/about.erb                   | 12 ++++
 test/fixtures/src/assets/icons/thumbs_up.svg  |  1 +
 test/fixtures/src/index.html                  | 20 +++++-
 test/test_bridgetown_svg_inliner.rb           | 64 +++++++++++++++----
 7 files changed, 86 insertions(+), 17 deletions(-)
 create mode 100644 test/fixtures/src/about.erb
 create mode 100644 test/fixtures/src/assets/icons/thumbs_up.svg

diff --git a/lib/bridgetown-svg-inliner/builder.rb b/lib/bridgetown-svg-inliner/builder.rb
index 458d8da..ead9654 100644
--- a/lib/bridgetown-svg-inliner/builder.rb
+++ b/lib/bridgetown-svg-inliner/builder.rb
@@ -20,7 +20,7 @@ def build
     def render(path, html_attributes)
       file = File.read(site.in_source_dir(path))
       xml = Nokogiri::XML(file)
-      html_attributes.each { |key, value| xml.root.set_attribute(key, value) }
+      html_attributes&.each { |key, value| xml.root.set_attribute(key, value) }
       xml.root.to_xml.html_safe
     end
   end
diff --git a/lib/bridgetown-svg-inliner/liquid_attributes.rb b/lib/bridgetown-svg-inliner/liquid_attributes.rb
index 38ec227..2f1e045 100644
--- a/lib/bridgetown-svg-inliner/liquid_attributes.rb
+++ b/lib/bridgetown-svg-inliner/liquid_attributes.rb
@@ -10,7 +10,7 @@ def initialize(attributes)
       @path = unescape_string(path)
       @args = args.scan(Liquid::TagAttributes).map do |arg|
         [arg[0], unescape_string(arg[1])]
-      end.to_h
+      end.to_h if args.present?
     end
 
     private
diff --git a/test/fixtures/src/_data/site_metadata.yml b/test/fixtures/src/_data/site_metadata.yml
index de68414..dbfbd23 100644
--- a/test/fixtures/src/_data/site_metadata.yml
+++ b/test/fixtures/src/_data/site_metadata.yml
@@ -1 +1 @@
-title: Override Me
\ No newline at end of file
+title: SVG Inliner
diff --git a/test/fixtures/src/about.erb b/test/fixtures/src/about.erb
new file mode 100644
index 0000000..a22d7cd
--- /dev/null
+++ b/test/fixtures/src/about.erb
@@ -0,0 +1,12 @@
+---
+layout: default
+template_engine: erb
+---
+
+<figure id="base">
+  <%= svg "/assets/icons/thumbs_up.svg" %>
+</figure>
+
+<figure id="with-attributes">
+  <%= svg "/assets/icons/thumbs_up.svg", class: "icon", id: "upvote" %>
+</figure>
\ No newline at end of file
diff --git a/test/fixtures/src/assets/icons/thumbs_up.svg b/test/fixtures/src/assets/icons/thumbs_up.svg
new file mode 100644
index 0000000..f60e4d1
--- /dev/null
+++ b/test/fixtures/src/assets/icons/thumbs_up.svg
@@ -0,0 +1 @@
+<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512"><path d="M466.27 286.69C475.04 271.84 480 256 480 236.85c0-44.015-37.218-85.58-85.82-85.58H357.7c4.92-12.81 8.85-28.13 8.85-46.54C366.55 31.936 328.86 0 271.28 0c-61.607 0-58.093 94.933-71.76 108.6-22.747 22.747-49.615 66.447-68.76 83.4H32c-17.673 0-32 14.327-32 32v240c0 17.673 14.327 32 32 32h64c14.893 0 27.408-10.174 30.978-23.95 44.509 1.001 75.06 39.94 177.802 39.94 7.22 0 15.22.01 22.22.01 77.117 0 111.986-39.423 112.94-95.33 13.319-18.425 20.299-43.122 17.34-66.99 9.854-18.452 13.664-40.343 8.99-62.99zm-61.75 53.83c12.56 21.13 1.26 49.41-13.94 57.57 7.7 48.78-17.608 65.9-53.12 65.9h-37.82c-71.639 0-118.029-37.82-171.64-37.82V240h10.92c28.36 0 67.98-70.89 94.54-97.46 28.36-28.36 18.91-75.63 37.82-94.54 47.27 0 47.27 32.98 47.27 56.73 0 39.17-28.36 56.72-28.36 94.54h103.99c21.11 0 37.73 18.91 37.82 37.82.09 18.9-12.82 37.81-22.27 37.81 13.489 14.555 16.371 45.236-5.21 65.62zM88 432c0 13.255-10.745 24-24 24s-24-10.745-24-24 10.745-24 24-24 24 10.745 24 24z"/></svg>
\ No newline at end of file
diff --git a/test/fixtures/src/index.html b/test/fixtures/src/index.html
index 50bd269..6acc79e 100644
--- a/test/fixtures/src/index.html
+++ b/test/fixtures/src/index.html
@@ -2,4 +2,22 @@
 layout: default
 ---
 
-Testing this plugin: {% sample_plugin %}
+<figure id="base">
+  {% svg "/assets/icons/thumbs_up.svg" %}
+</figure>
+
+<figure id="with-attributes">
+  {% svg "/assets/icons/thumbs_up.svg", class: "icon", id: "upvote" %}
+</figure>
+
+<figure id="without-quotes">
+  {% svg /assets/icons/thumbs_up.svg, class: icon %}
+</figure>
+
+<figure id="with-liquid-variables">
+  {% assign svg_file = "thumbs_up" %}
+  {% assign svg_class_list = "icon icon--small" %}
+
+  {% svg "/assets/icons/{{ svg_file }}.svg", class: "{{ svg_class_list }}" %}
+</figure>
+
diff --git a/test/test_bridgetown_svg_inliner.rb b/test/test_bridgetown_svg_inliner.rb
index 044af96..27bdbfb 100644
--- a/test/test_bridgetown_svg_inliner.rb
+++ b/test/test_bridgetown_svg_inliner.rb
@@ -4,28 +4,66 @@
 
 class TestBridgetownSvgInliner < Minitest::Test
   def setup
-    @site = Bridgetown::Site.new(Bridgetown.configuration(
-                                   "root_dir"    => root_dir,
-                                   "source"      => source_dir,
-                                   "destination" => dest_dir,
-                                   "quiet"       => true
-                                 ))
+    @site = Bridgetown::Site.new(
+      Bridgetown.configuration(
+        "root_dir"    => root_dir,
+        "source"      => source_dir,
+        "destination" => dest_dir,
+        "quiet"       => true
+      )
+    )
   end
 
-  context "sample plugin" do
+  context "rendering an SVG using the liquid tag" do
     setup do
-      with_metadata title: "My Awesome Site" do
+      with_metadata title: "SVG Inliner" do
         @site.process
-        @contents = File.read(dest_dir("index.html"))
+        @contents = Nokogiri::HTML(File.read(dest_dir("index.html")))
       end
     end
 
-    should "output the overridden metadata" do
-      assert_includes @contents, "<title>My Awesome Site</title>"
+    should "output the SVG file" do
+      assert_valid_svg "#base > svg"
     end
 
-    should "output the sample Liquid tag" do
-      assert_includes @contents, "This plugin works!"
+    should "output the SVG with attributes passed into the tag" do
+      assert_valid_svg "#with-attributes > svg.icon"
+      assert_valid_svg "#upvote"
     end
+
+    should "output the SVG when quotes are not used in the arguments" do
+      assert_valid_svg "#without-quotes > svg.icon"
+    end
+
+    should "output the SVG interpolating liquid variables in the arguments" do
+      assert_valid_svg "#with-liquid-variables > svg.icon.icon--small"
+    end
+  end
+
+  context "rendering an SVG using the ERB helper" do
+    setup do
+      with_metadata title: "SVG Inliner" do
+        @site.process
+        @contents = Nokogiri::HTML(File.read(dest_dir("about.html")))
+      end
+    end
+
+    should "output the SVG file" do
+      assert_valid_svg "#base > svg"
+    end
+
+    should "output the SVG with attributes passed into the helper" do
+      assert_valid_svg "#with-attributes > svg.icon"
+      assert_valid_svg "#upvote"
+    end
+  end
+
+  private
+
+  def assert_valid_svg(selector)
+    svg_node = @contents.at_css(selector)
+
+    assert_equal "svg", svg_node.name
+    refute_nil svg_node.children.find { _1.name == "path" }
   end
 end