Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bufferStoragePath gets set to "" #178

Closed
aza547 opened this issue Sep 27, 2022 · 3 comments
Closed

bufferStoragePath gets set to "" #178

aza547 opened this issue Sep 27, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@aza547
Copy link
Owner

aza547 commented Sep 27, 2022

image

image

2022-09-27_11-41-58 (1).txt
WarcraftRecorder-2022-09-27 (3).log
config-v2 (2).json.txt

@aza547 aza547 added the bug Something isn't working label Sep 27, 2022
@aza547
Copy link
Owner Author

aza547 commented Sep 27, 2022

Possible user set this by accident? We should guard against that

@aza547
Copy link
Owner Author

aza547 commented Sep 28, 2022

Managed to repro the empty buffer config.

  1. Delete config file.
  2. Open settings. Press save with no changes.
  3. Defaults are written to json. Including "" as bufferStoragePath.
    Not quite sure how the users hit this though as it seemed to happen spontaneously on an otherwise well configured setup.

Still TBD that - the trigger from above is that storagePath is saved as an empty string so evaluates to false, so we fall back to the default for bufferStoragePath which is never valid to do.
I don't think it's possible to save an empty storagePath after first time setup (it's only configurable via the file dialog selector which doesn't let you select "")

@aza547
Copy link
Owner Author

aza547 commented Oct 2, 2022

Fixed in next release.

@aza547 aza547 closed this as completed Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant