Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random Javascript Error #199

Closed
taylorwastaken opened this issue Oct 10, 2022 · 19 comments
Closed

Random Javascript Error #199

taylorwastaken opened this issue Oct 10, 2022 · 19 comments

Comments

@taylorwastaken
Copy link

Just keep getting random javascript errors while running keys.

WarcraftRecorder-2022-10-09.log

@aza547
Copy link
Owner

aza547 commented Oct 10, 2022

Could you also share the OBS logs? In a folder at the location the log button in the app takes you to.

@taylorwastaken
Copy link
Author

@taylorwastaken
Copy link
Author

javascript2
javascript3
javascript1

here are the three errors that pop up. I was not doing any key just had wow open and then I let it disconnect from time out.

@taylorwastaken
Copy link
Author

2022-10-10 08-02-31.txt
heres the OBS log associated with those images

@aza547
Copy link
Owner

aza547 commented Oct 10, 2022

Might be the same as #194.

What is the type disk you are saving to?

@aza547
Copy link
Owner

aza547 commented Oct 10, 2022

Almost certain it's the same issue.

13 minutes to cut the video in one instance.

Looks like you started another key before it was done cutting.

We have fixes in the work for this, hopefully available next weekend sorry you have hit this.

If you have a faster disk you can use meanwhile that might help.

@taylorwastaken
Copy link
Author

its saving to a regular HDD, ill change to have it save to my SSD. Thanks

@aza547
Copy link
Owner

aza547 commented Oct 10, 2022

Closing as a duplicate of #194

@aza547 aza547 closed this as completed Oct 10, 2022
@taylorwastaken
Copy link
Author

just adding more to this. I moved my recordings to the ssd and still received similar errors
WarcraftRecorder-2022-10-10.log
WarcraftRecorder-2022-10-11.log
2022-10-10 22-03-53.txt
2022-10-11 08-10-46.txt
javascript5
javascript6
javascript4

@taylorwastaken
Copy link
Author

I achieved this by just pressing the record button and then stopping it. and then trying to record again.

@aza547
Copy link
Owner

aza547 commented Oct 11, 2022

Well that's interesting...
The move to SSD seems to have worked and sped up the cutting.

[2022-10-11 11:02:01.933] [info]  [Util] Ready to cut video.
[2022-10-11 11:02:03.053] [info]  [Util] FFmpeg cut video succeeded

That took 2 seconds, which is within what I expect.

So this looks like something new.

@aza547 aza547 reopened this Oct 11, 2022
@aza547
Copy link
Owner

aza547 commented Oct 11, 2022

I can see you've spammed your test button a bit - can you retry this by restarting the app and clicking the test button only once? I think this might be the cause of your problem.

Although we have a guard meant to prevent this happening, it's clearly not working! I've fixed that here:

@taylorwastaken
Copy link
Author

looks like that was it, i couldnt tell if it had started so i clicked it alot. but yea i just waited a bit and go it no errors. thanks again!

@aza547
Copy link
Owner

aza547 commented Oct 11, 2022

Great, no worries! Thanks for the report!

@aza547 aza547 closed this as completed Oct 11, 2022
@taylorwastaken
Copy link
Author

i hate to keep reopening this but it happened again and i wasnt even in a key or anything just launching the game from beta back to live. same style javascript errors as posted above
WarcraftRecorder-2022-10-12.log
2022-10-11 20-13-53.txt

@aza547
Copy link
Owner

aza547 commented Oct 12, 2022

No need to feel guilty, bug reports like this are super helpful! I'll look shortly.

@aza547 aza547 reopened this Oct 12, 2022
@aza547
Copy link
Owner

aza547 commented Oct 12, 2022

Strange one this time. Again different than the last. I need some more time for this, but meanwhile you should take 2.9.0. There were some fixes in this area and it might just go away.

@aza547
Copy link
Owner

aza547 commented Oct 21, 2022

Are you still having issues here? @taylorwastaken

@taylorwastaken
Copy link
Author

Not since I updated to the latest and swapped to the ssd. Thanks! I didn’t realize this was still open my bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants