Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown encounter throws error #236

Closed
aza547 opened this issue Nov 29, 2022 · 4 comments
Closed

Unknown encounter throws error #236

aza547 opened this issue Nov 29, 2022 · 4 comments

Comments

@aza547
Copy link
Owner

aza547 commented Nov 29, 2022

image

WarcraftRecorder-2022-11-28.log

@aza547
Copy link
Owner Author

aza547 commented Nov 29, 2022

We should handle this gracefully - i.e. not crash.

@aza547
Copy link
Owner Author

aza547 commented Nov 29, 2022

Up for debate if we should still record.

@aza547
Copy link
Owner Author

aza547 commented Dec 1, 2022

Partial fix for this in will stop us trying to record dungeon bosses (for norm, hc, m0 dungeons).

Still want to make genuinely unknown encounters more robust.

@aza547
Copy link
Owner Author

aza547 commented Dec 3, 2022

Fixed on main.

@aza547 aza547 closed this as completed Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant