Mexican summer time change causing wrongly clipped videos

[aza547]

Hey, i shared a couple of comments with Aza on the compwow reddit about the app behaving weirdly on raid recordings, the recordings don't start at the pull of the boss and get cutoff before the wipe happens, heres the logs

all the recordings i have are from mythic rasza pulls, and i've noticed that all recordings start right as the boss resets from the previous wipe, and then cutoff before the raid actually wipes

i've also noticed that all the recordings have the right lenghts, as in the video is exactly as long as the fight was according to the log uploaded to warcraftlogs, but it starts at the previous wipe and then ends when that lenght is reached before the fight actually ends

That could be it, ive been having issues with discord showing 1 hour later than my pc clock since the last daylight savings, it might be cause my country used to change times for daylight savings but stopped doing it this year

[aza547]

WarcraftRecorder-2023-04-25 (1).log

[aza547]

The logs show clipping around the hour mark always, suspect getting away with that in M+ by just including an extra bit at the start of the video but still wrong behaviour.

Wondered if it was something at the nodeJS level...

[aza547]

As far as I can tell NodeJS has been updated with the new timezone data, but it still looks like its getting it wrong.

[2023-04-25 13:54:19.256] [info] [Recorder] Start OBS called
[2023-04-25 13:54:19.303] [info] [Recorder] Got signal: { type: 'recording', signal: 'start', code: 0, error: '' }

[2023-04-25 14:01:54.007] [info] [VideoProcessQueue] Queuing video for processing {
bufferFile: 'H:\Recordings\M+ Runs\.temp\2023-04-25 12-54-19.mp4',

Notice how at 13:54 NodeJS time we start recording. But that produces a video that's timestamped by OBS at 12:54. So it appears OBS knows about the real timezone but NodeJS doesn't.

Wow also appears to know about the real timezone:

[2023-04-25 13:54:51.282] [debug] [RetailLogHandler] Handling CHALLENGE_MODE_START line: {
original: '4/25 12:54:27.571 CHALLENGE_MODE_START,"The Nokhud Offensive",2516,400,20,[9,7,3,132]',

Again notice how NodeJS time is 13:54 but the WoW combat log time is 12:54.

[aza547]

Hoping to get more logs from the user, I added a explicit time zone log in a recent version. It would be good to know what NodeJS thinks its in. It sounds like some areas of Mexico still use daylight saving and some do not. Possibly confusion over this could be the cause?

[aza547]

electron/electron#37972 this maybe? Wasn't expecting it to be dependent on electron but we're using 18.X.X still. I'll try bump that and see what breaks...

[aza547]

Everything seemed to just work... neat. Lots of other issues on electrons github page regarding timezone data propagation, so seems likely this is fixed.