-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support classic WoW [Classic sample logs wanted!] #50
Comments
Submitting classic logs will help this loads. I don't play classic currently so have no access to them. Submit your arena/raid/whatever logs and I can try get a head start on this feature! |
I added a classic arena log in the resources dir. Sadly no arena events found, looks like we'll need to rely on ZONE_CHANGE stuff. TBD if we can count on the ZONE_CHANGE firing at the end of the game reliably (without flushing delay issues) like we can on retail. I'm going to assume no, as the log I uploaded doesn't have have a ZONE_CHANGE log in it. I used ACL for classic logging, maybe SCL is better if it works. |
OK, SCL works and has the "delay end by 30s" function. Hopefully that is enough to catch final ZONE_CHANGE events? |
Seems SCL doesn't work despite loading OK. Played a skirm and it didn't trigger logs. |
WoWCombatLog-091822_152136 (2).txt This is actually a .7z file but I had to rename it to make github accept it. Needs unzipped, but contains a log of a mount hyjal run with all boss kills (I think 1 wipe on KJ). |
This is in main now |
I'm actually going to be playing classic so interested in this!
The main blocker to implementing this is lack of logs. Surely can get some from somewhere.
The text was updated successfully, but these errors were encountered: