Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spacebar to start/stop video binds #537

Closed
aza547 opened this issue Sep 29, 2024 · 2 comments
Closed

Add spacebar to start/stop video binds #537

aza547 opened this issue Sep 29, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@aza547
Copy link
Owner

aza547 commented Sep 29, 2024

{75D6CC98-FE10-4842-8B70-3635C7D4E211}

@aza547 aza547 added the enhancement New feature or request label Sep 29, 2024
@vaisest
Copy link
Contributor

vaisest commented Oct 7, 2024

I noticed from my media key issue that this is a very simple change:

--- a/src/renderer/VideoPlayer.tsx
+++ b/src/renderer/VideoPlayer.tsx
@@ -721,8 +721,9 @@ export const VideoPlayer = (props: IProps) => {
       return;
     }

-    if (e.key === 'k') {
+    if (e.key === 'k' || e.key === ' ') {
       togglePlaying();
+      e.preventDefault();
     }

     if (e.key === 'j' || e.key === 'ArrowLeft') {

Though it prevents space from scrolling down the list and working during when selecting buttons with tab. Is this the intention?

@aza547
Copy link
Owner Author

aza547 commented Oct 11, 2024

Thanks. I've grabbed this change. It was never intentional for space to have any effects otherwise so happy to lose those.

@aza547 aza547 closed this as completed in e1c3c79 Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants