-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microphone streaming causes windows to not sleep/hibernate #57
Comments
Thanks for the report. Will look at fixing soon. |
I was doing a few tests on this yesterday and I think it stems from OBS recording in the background before the actual recording of content is triggered. Is that a fair assumption? I tried a simple commenting out of |
This can only realistically be fixed by not recording sound (disabling the sound sources) while recording the buffer and only enabling the sound when we detect an event that starts the recording, but that obviously would mean we could lose up to like 30 seconds of audio in the beginning. |
Would it be possible to check if the game is running and if not just stop recording to the buffer? the game will also stop windows from sleeping. |
Yes, that would totally be possible and an easy fix. |
We already do this? |
Yes, but the audio sources are still being kept open by OBS even if you stop buffer recording. Check out #204 for a possible fix to this. |
I've backed this out as the fix was causing #220 |
A fix for this is finally coming in the next release. |
Ugh, design changed a bit and makes this harder: https://obsproject.com/forum/threads/obs-prevents-screen-sleep-any-work-around.111687/. Seems that if OBS is initialized we'll never be able to sleep. A good option seems to be shutdown OBS when WoW is closed - but that takes a few seconds of synchronous programming that isn't acceptable from a UX point of view. I'm going to look at how I can use Node to do this in a separate thread. Seems gross, but the alternate is having the app lock up for 2-3s every time WoW opens/closes. |
OK, back in business on this. I re-examined the fix @tdaugaard made and found the issue which was it was clearing the video source in addition to the audio sources. Fixed in the next release, so closing. |
Microphone recording stops windows from windows from sleeping on its own. From the terminal command "powercfg -requests" with the application in the task bar (WOW not running):
After closing the wow-recorder app:
The text was updated successfully, but these errors were encountered: