Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recordings cut short #64

Closed
aza547 opened this issue Aug 31, 2022 · 9 comments
Closed

Recordings cut short #64

aza547 opened this issue Aug 31, 2022 · 9 comments
Labels
bug Something isn't working

Comments

@aza547
Copy link
Owner

aza547 commented Aug 31, 2022

Suspect zone_change handling problem.

  1. Recording starts over after 10 minutes (Sylvanas fight is long) and only saves the rest of the fight. Total clip length was 1:44 instead of 11:44.
  2. Recording the whole fight.
  3. The rec button I imagine. I didn't have the application open during but all the other fights were recorded correctly.
  4. Version 2.5.2, I downloaded the application today
    WarcraftRecorder-2022-08-31.log
@aza547
Copy link
Owner Author

aza547 commented Aug 31, 2022

Suspect promise rejection in logs is a symptom of repeatedly starting OBS because the buffer recording restart kicks in during a real recording.

[2022-08-31 21:16:56.498] [error] (node:13012) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 3)

@aza547
Copy link
Owner Author

aza547 commented Aug 31, 2022

@aza547
Copy link
Owner Author

aza547 commented Aug 31, 2022

Probably not a zone change problem. For some reason the cutting took nearly 3 mins. Something must have gone wrong with the async logic as a result?

@aza547
Copy link
Owner Author

aza547 commented Aug 31, 2022

another person, same problem

Issue 1: Constant beeping during videos.
Issue 2: Recordings of KT and Sylvanas pulls are not working. It says the correct pull time on the small thumbnail but actual playtime is wrong. Only showing like 2min 50sec of a 9 min 40 pull and such

WarcraftRecorder-2022-08-31 (3).log

image

Some pulls were not recorded at all
And all pulls were like this
KT and Sylvanas were not working, let me check the other 7 bosses real quick
The other fights works. So seems to be fights with separate phases or realms

@aza547 aza547 changed the title Sylvanas recording cut short Sylvanas and KT recordings cut short Aug 31, 2022
@aza547
Copy link
Owner Author

aza547 commented Sep 1, 2022

Another instance of this on different bosses:

image
2022-09-01_19-45-02.txt
WarcraftRecorder-2022-09-01 (1).log

@aza547
Copy link
Owner Author

aza547 commented Sep 1, 2022

[2022-09-01 20:26:20.222] [info]  Recorder: Start recording buffer
[2022-09-01 20:26:20.223] [debug] OBS is now recording...
[2022-09-01 20:26:20.223] [debug] Started?
[2022-09-01 20:26:20.314] [debug] Started signalInfo.type: recording (expected: "recording")
[2022-09-01 20:26:20.315] [debug] Started signalInfo.signal: start (expected: "start")
[2022-09-01 20:26:20.315] [debug] Started!
[2022-09-01 20:27:11.951] [info]  Recorder: Start recording
[2022-09-01 20:30:09.604] [info]  Recorder: Restart recording buffer
[2022-09-01 20:30:09.606] [debug] OBS stopping recording...
[2022-09-01 20:30:09.637] [debug] On stop signalInfo.type: recording (expected: "recording")
[2022-09-01 20:30:09.637] [debug] On stop signalInfo.signal: stopping (expected: "stopping")
[2022-09-01 20:30:09.826] [debug] After stop signalInfo.type: recording (expected: "recording")
[2022-09-01 20:30:09.827] [debug] After stop signalInfo.signal: stop (expected: "stop")
[2022-09-01 20:30:09.827] [debug] Stopped!
[2022-09-01 20:30:11.609] [info]  Deleting: C:/Users/alexs/AppData/Local/Temp/WarcraftRecorder/2022-09-01 20-25-11.mp4
[2022-09-01 20:30:11.638] [debug] OBS is now recording...
[2022-09-01 20:30:11.638] [debug] Started?
[2022-09-01 20:30:11.724] [debug] Started signalInfo.type: recording (expected: "recording")
[2022-09-01 20:30:11.725] [debug] Started signalInfo.signal: start (expected: "start")
[2022-09-01 20:30:11.725] [debug] Started!
[2022-09-01 20:32:57.934] [info]  Recorder: Stop recording after 15 seconds
[2022-09-01 20:32:57.934] [info]  Recorder: {"name":"name","category":"Raids","encounterID":2433,"duration":361,"result":true}
[2022-09-01 20:33:12.936] [debug] OBS stopping recording...
[2022-09-01 20:33:12.968] [debug] On stop signalInfo.type: recording (expected: "recording")
[2022-09-01 20:33:12.968] [debug] On stop signalInfo.signal: stopping (expected: "stopping")
[2022-09-01 20:33:13.158] [debug] After stop signalInfo.type: recording (expected: "recording")
[2022-09-01 20:33:13.158] [debug] After stop signalInfo.signal: stop (expected: "stop")
[2022-09-01 20:33:13.158] [debug] Stopped!
[2022-09-01 20:33:15.039] [info]  Video start time was:  -180
[2022-09-01 20:33:15.040] [info]  Avoiding error by not cutting video
[2022-09-01 20:33:15.040] [info]  Ready to cut video.
[2022-09-01 20:33:15.040] [info]  Initial duration: 181.217 Desired duration: 361 Calculated start time: 0
[2022-09-01 20:33:15.862] [info]  FFmpeg cut video succeeded
[2022-09-01 20:33:15.961] [info]  Deleting: C:/Users/alexs/AppData/Local/Temp/WarcraftRecorder/2022-09-01 20-26-20.mp4

Thoughts:

  • Looks like recording buffer restart kicked in mid-recording.
  • We are meant to cancel the time on the call to recorder.start()
  • That's not happened for some reason. Not sure why.

@aza547 aza547 changed the title Sylvanas and KT recordings cut short Recordings cut short Sep 1, 2022
@computerchipdotbiz
Copy link

computerchipdotbiz commented Sep 2, 2022

This is happening to me also, the only full BG video I got was the very first BG I did, and after that, it only captures pretty much the last few mins or few seconds of the BG.

Let me know if you need any additional info or logs, and thank you for making this app.

@computerchipdotbiz
Copy link

2022-09-01_21-15-39.mp4

@aza547 aza547 added the bug Something isn't working label Sep 3, 2022
@aza547
Copy link
Owner Author

aza547 commented Sep 4, 2022

Should be fixed in 2.6.0. Closing.

@aza547 aza547 closed this as completed Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants