-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to using aws_launch_template vs. aws_launch_configuration #30
Comments
Unblocked by hashicorp/terraform-provider-aws#5632, which is in v1.34.0+ of the AWS Terraform provider. |
I feel like I'm missing something. I believe there was another Terraform module we wanted to cut a release on in tandem with merging this change. Also, with #34, I believe we paired and setup testing environments out-of-band, which is why the testing instructions were left unfinished. I am going to test again and I will update the PR body. |
I don't think that we have to bundle the issues referenced with this one. I think that the two modules we wanted to release in tandem was this and I updated the status of this issue, but it isn't in our current sprint yet, so I would hold off on updating the PR until we add it to a sprint. |
Looks like this is the new way to provide instance level parameters for ASGs. After a quick review, it appears that all of the arguments we're currently providing to
aws_launch_configuration
are supported byaws_launch_template
(block_device_mappings
looks like the only one that isn't straightforward).The motivation for migrating to
aws_launch_template
is to support enabling T2 Unlimited support viacredit_specification
.See: https://www.terraform.io/docs/providers/aws/r/launch_template.html
The text was updated successfully, but these errors were encountered: