Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GameModeSelectionState has unlimited event channel loop #134

Closed
azriel91 opened this issue Mar 12, 2020 · 0 comments
Closed

GameModeSelectionState has unlimited event channel loop #134

azriel91 opened this issue Mar 12, 2020 · 0 comments
Assignees
@azriel91
Labels
M: code Code maintenance and quality.
Milestone
Maintenance - 201...

Comments

@azriel91
Copy link
Owner

In GitLab by @azriel91 on Jun 4, 2019, 10:52

Fix GameModeSelectionState from its unlimited event channel loop.

The AppEventReader will read from EventChannel<GameModeSelectionEvent>, so when we handle_event(), we shouldn't write to the channel otherwise any events written will forever be in this event channel cycle.
@azriel91 azriel91 added the M: code Code maintenance and quality. label Mar 12, 2020
@azriel91 azriel91 added this to the Maintenance - 2019-06 milestone Mar 12, 2020
@azriel91 azriel91 self-assigned this Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azriel91 azriel91

Labels
M: code Code maintenance and quality.
Projects
None yet
Milestone
Maintenance - 2019-06
Development

No branches or pull requests
1 participant
@azriel91