[counterpoll] add port buffer drop group #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
Co-authored-by: Danny Allen <daall@microsoft.com>
Co-authored-by: Danny Allen <daall@microsoft.com>
|
need unit test |
Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
daall
reviewed
Aug 20, 2020
added 2 commits
August 27, 2020 14:25
* Fix review comments Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>
…o buffer_drop Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com> Conflicts: tests/mock_tables/config_db.json
|
retest this please |
daall
approved these changes
Aug 27, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mykola Faryma mykolaf@mellanox.com
Introducing separate FC group for port lever buffer drop counters as discussed in sonic-net/sonic-swss#1308
- What I did
- How I did it
- How to verify it
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)